[releases/2.1] Cherry-pick: [High priority] Measurement Client: Raise errors for invalid enums #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fix: Raise errors for invalid enums * Refactor: Method names for clarity * Fix: Transform invalid enum values * Tests: Add unit tests for client * Revert: main.py change * Fix: Refine regex in support.py * Tests: Update expected and actual assert positioning (cherry picked from commit 4a4c464)
MounikaBattu17
requested review from
csjall,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
|
@dixonjoel Can you please help approve this cherry-pick PR. Thanks. |
bkeryan
approved these changes
Sep 23, 2024
dixonjoel
deleted the
users/mounika/cherry-pick-validate-enum-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick the change in PR #916.